Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComfyUI Tool realtive WS paths #13029

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

ComfyUI Tool realtive WS paths #13029

wants to merge 7 commits into from
+297 −10

Conversation

bikevit2008
Copy link

@bikevit2008 bikevit2008 commented Jan 24, 2025 •
edited by crazywoola
Loading

Summary

Close #13061

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Vitaly added 2 commits January 25, 2025 02:11
Relative WS path for comfyui
56c73da 
By default now we can use links like abc.com/ but abc.com/foo/bar/comfy is not valid
Merge branch 'main' of https://github.com/bikevit2008/dify
85fdc5f
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Jan 24, 2025
@bikevit2008
Copy link
Author

Sorry i have not time to best description, but in commit you can view description and simple code update

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 25, 2025
@crazywoola
Copy link
Member

crazywoola commented Jan 26, 2025 •
edited
Loading

Please open an issue or link an existing issue. :)
Please fix the lint errors as well by running ./dev/reformat.

@bikevit2008
Copy link
Author

#13061

@bikevit2008
Copy link
Author

Please open an issue or link an existing issue. :) Please fix the lint errors as well by running ./dev/reformat.

./dev/reformat how to start it and from?)

@crazywoola
Copy link
Member

Please open an issue or link an existing issue. :) Please fix the lint errors as well by running ./dev/reformat.

./dev/reformat how to start it and from?)

You need to run the command in the root dir.

@bikevit2008
Copy link
Author

Did it

Please open an issue or link an existing issue. :) Please fix the lint errors as well by running ./dev/reformat.

./dev/reformat how to start it and from?)

You need to run the command in the root dir.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 28, 2025
@bikevit2008 bikevit2008 mentioned this pull request Jan 28, 2025
Open
5 tasks
@bikevit2008 bikevit2008 mentioned this pull request Jan 28, 2025
Open
5 tasks
crazywoola
crazywoola reviewed Jan 30, 2025
View reviewed changes
docker/docker-compose.yaml
@@ -393,7 +393,9 @@ x-shared-env: &shared-api-worker-env
services:
# API service
api:
image: langgenius/dify-api:0.15.2
build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the changes here.

crazywoola
crazywoola reviewed Jan 30, 2025
View reviewed changes
api/core/tools/tool_file_manager.py
# Проверяем наше сопоставление MIME-типов
extension = MIME_TO_EXTENSION.get(mimetype)
if not extension:
# Если нет в нашем сопоставлении, пробуем стандартный способ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the comments in English only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🔨 feat:tools Tools for agent, function call related stuff. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative WS path for comfyui
2 participants
@bikevit2008 @crazywoola