fix: filter empty value in xlsx to improve vector similarity hit #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takatost
approved these changes
Jun 21, 2023
|
Btw, How much of an impact does None have on dataset retrieval? Is there any comparison that we can refer to? |
JohnJyong
approved these changes
Jun 21, 2023
Octivian
pushed a commit
to Octivian/dify
that referenced
this pull request
Aug 8, 2023
HuberyHuV1
pushed a commit
to HuberyHuV1/dify
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude empty value during xlsx parsing, to make hit-test result more accurate.
By the way, we should exclude any redundant text in original dataset, so that the indexing and query result can be more accurate.
Fix: #388