Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:retieval setting document link 404 #5861

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Jul 2, 2024

Description

Fix retieval setting document link 404.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@iamjoel iamjoel requested a review from zxhlyh July 2, 2024 07:58
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Jul 2, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2024
@iamjoel iamjoel merged commit a33ce09 into main Jul 2, 2024
6 checks passed
@iamjoel iamjoel deleted the fix/retrieval-setting-document-404 branch July 2, 2024 08:02
ZhouhaoJiang added a commit that referenced this pull request Jul 4, 2024
* refs/heads/main: (36 commits)
  feat: add claude3 function calling (#5889)
  refactor: Create a `dify_config` with Pydantic. (#5938)
  fix: zhipuai pytest correction (#5934)
  docs(api/core/tools/docs/en_US/tool_scale_out.md): Format by markdownlint. (#5903)
  chore: remove dify SaaS URL in default configs (#5888)
  feat: pr template (#5886)
  fix bug : TencentVectorDBConfig Add  TENCENT_VECTOR_DB_DATABASE (#5879)
  refactor(api/core/app/apps/base_app_generator.py): improve input validation and sanitization in BaseAppGenerator (#5866)
  chore:  click area that trigger showing tracing config is too large (#5878)
  Fix/remove tsne position test (#5858)
  Fix/docker env namings (#5857)
  doc: docker-compose won't start due to wrong README (#5859)
  fix:retieval setting document link 404 (#5861)
  chore:remove .env.example duplicate key (#5853)
  fix: not show opening question if the opening message is empty (#5856)
  fix: react.js error 185 maximum update depth exceeded in streaming responses during conversation (#5849)
  Ensure *.sh are LF-style, so that they can be used directly by Docker for Windows (#5793)
  feat: add export permission (#5841)
  feat: update LangfuseConfig host config (#5846)
  fix:unable to select workplace at the bottom (#5785)
  ...
ZhouhaoJiang added a commit that referenced this pull request Jul 4, 2024
* refs/heads/feat/knowledge-admin-role:
  feat: dataset documents rename permission
  feat: add claude3 function calling (#5889)
  refactor: Create a `dify_config` with Pydantic. (#5938)
  fix: zhipuai pytest correction (#5934)
  docs(api/core/tools/docs/en_US/tool_scale_out.md): Format by markdownlint. (#5903)
  chore: remove dify SaaS URL in default configs (#5888)
  feat: pr template (#5886)
  fix bug : TencentVectorDBConfig Add  TENCENT_VECTOR_DB_DATABASE (#5879)
  refactor(api/core/app/apps/base_app_generator.py): improve input validation and sanitization in BaseAppGenerator (#5866)
  chore:  click area that trigger showing tracing config is too large (#5878)
  Fix/remove tsne position test (#5858)
  Fix/docker env namings (#5857)
  doc: docker-compose won't start due to wrong README (#5859)
  fix:retieval setting document link 404 (#5861)
  chore:remove .env.example duplicate key (#5853)
  fix: not show opening question if the opening message is empty (#5856)
  fix: react.js error 185 maximum update depth exceeded in streaming responses during conversation (#5849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants