Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add status_code 304 #6000

Merged
merged 3 commits into from
Jul 5, 2024
Merged

fix: add status_code 304 #6000

merged 3 commits into from
Jul 5, 2024

Conversation

opriuwohg
Copy link
Contributor

@opriuwohg opriuwohg commented Jul 5, 2024

When requesting static resources, do not use status code 200 as the sole criterion for determining success, so I have added that status code 304 can also be used as a criterion for success.

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

When requesting static resources, do not use status code 200 as the sole criterion for determining success, so I have added that status code 304 can also be used as a criterion for success.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2024
@opriuwohg opriuwohg changed the title add status_code fixes:add status_code Jul 5, 2024
@crazywoola crazywoola self-requested a review July 5, 2024 07:14
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jul 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2024
@crazywoola crazywoola changed the title fixes:add status_code fix: add status_code 304 Jul 5, 2024
@crazywoola crazywoola merged commit af98fd2 into langgenius:main Jul 5, 2024
5 checks passed
ZhouhaoJiang added a commit that referenced this pull request Jul 7, 2024
* refs/heads/fix/dataset_operator: (33 commits)
  feat: update dataset sort
  feat: add dataset_permissions tenant_id
  chore: optimize memory fetch performance (#6039)
  feat: support moonshot and glm base models for volcengine provider (#6029)
  Optimize db config (#6011)
  fix: token count includes base64 string of input images (#5868)
  chore: skip pip upgrade preparation in api dockerfile (#5999)
  feat(*): Swtich to dify_config. (#6025)
  fix: the input field of tool panel not worked as expected (#6003)
  Add 2 firecrawl tools : Scrape and Search (#6016)
  test(test_rerank): Remove duplicate test cases. (#6024)
  chore: optimize memory messages fetch count limit (#6021)
  Revert "feat: knowledge admin role" (#6018)
  feat: add Llama 3 and Mixtral model options to ddgo_ai.yaml (#5979)
  fix: add status_code 304 (#6000)
  6014 i18n add support for spanish (#6017)
  [Feature] Support loading for mermaid. (#6004)
  fix: update workflow trace query (#6010)
  Removed firecrawl-py, fixed and improved firecrawl tool (#5896)
  fix API tool's schema not support array (#6006)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants