-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add status_code 304 #6000
Merged
Merged
fix: add status_code 304 #6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requesting static resources, do not use status code 200 as the sole criterion for determining success, so I have added that status code 304 can also be used as a criterion for success.
crazywoola
approved these changes
Jul 5, 2024
crazywoola
requested changes
Jul 5, 2024
crazywoola
approved these changes
Jul 5, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Jul 7, 2024
* refs/heads/fix/dataset_operator: (33 commits) feat: update dataset sort feat: add dataset_permissions tenant_id chore: optimize memory fetch performance (#6039) feat: support moonshot and glm base models for volcengine provider (#6029) Optimize db config (#6011) fix: token count includes base64 string of input images (#5868) chore: skip pip upgrade preparation in api dockerfile (#5999) feat(*): Swtich to dify_config. (#6025) fix: the input field of tool panel not worked as expected (#6003) Add 2 firecrawl tools : Scrape and Search (#6016) test(test_rerank): Remove duplicate test cases. (#6024) chore: optimize memory messages fetch count limit (#6021) Revert "feat: knowledge admin role" (#6018) feat: add Llama 3 and Mixtral model options to ddgo_ai.yaml (#5979) fix: add status_code 304 (#6000) 6014 i18n add support for spanish (#6017) [Feature] Support loading for mermaid. (#6004) fix: update workflow trace query (#6010) Removed firecrawl-py, fixed and improved firecrawl tool (#5896) fix API tool's schema not support array (#6006) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting static resources, do not use status code 200 as the sole criterion for determining success, so I have added that status code 304 can also be used as a criterion for success.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax:
Fixes #<issue number>
, see documentation for more details.Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration