-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: couchbase integration #6165
Conversation
Hello @JohnJyong, do you have any comments? The only issue left to be fixed is disabling embedding models with a dimensionality > 2048. I'd like to ideally throw an error like this but I'm not sure how other vdb's like relyt are handling it |
@roadgoat19 Hello , sorry for the late response, we have working on some new features regarding RAG recently. Please resolve the conflicts and we can proceed with this PR. :) |
799e364
to
404b66b
Compare
@crazywoola I've fixed a lingering merge conflict, could you rerun the workflows please? |
Hello the API Tests (3.10) failed and there are some lint errors in the superlinter. |
@crazywoola Hello I believe I've fixed this issue causing the api tests to fail. However, I am a little unsure about how to fix the linter errors in the .env.example. When I run dev/reformat, it says that basically every single key is out of order. This issue persists even with the .env.example taken straight from the current main branch of dify. Is there a command I can run to fix this issue /or how should I proceed? |
Hello there are some conflicts here. And still got a lint error. I think you need to upgrade ruff and sync deps by |
b04ed0e
to
d140920
Compare
d140920
to
fa2ccfc
Compare
Thanks @crazywoola, and sorry for the delay here. I'm picking this PR up for @roadgoat19, and have resolved all conflicts and updated the dependencies. Let me know if anything else needs adjusting! |
bdac900
to
5e74274
Compare
5e74274
to
1a9f182
Compare
Hello @ejscribne Thanks for picking this up, please resolve those conflicts again :) |
1a9f182
to
6fbc762
Compare
Hey @crazywoola just fixed the conflicts, let me know if anything else needs to be done. Thanks! |
added longer setup sleep
Co-authored-by: Bowen Liang <bowenliang@apache.org>
0a97ed4
to
68060d1
Compare
Hey @crazywoola sorry for the delay fixing this, added a healthcheck to be sure the resource is ready for the tests. It should fix the issue. |
9495951
to
69e06af
Compare
Finally |
Co-authored-by: crazywoola <427733928@qq.com> Co-authored-by: Elliot Scribner <elliot.scribner@couchbase.com> Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com> Co-authored-by: Bowen Liang <bowenliang@apache.org>
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax:
Fixes #<issue number>
, see documentation for more details.Fixes #5178
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration