Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move dev packages to devDependencies #719

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

shunyue1320
Copy link
Contributor

No description provided.

@@ -64,6 +64,7 @@ module.exports = {
},
},
plugins: [
require('@tailwindcss/line-clamp'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tailwind CSS v3.3 the line-clamp utilities are now included in the framework by default(https://github.com/tailwindlabs/tailwindcss-line-clamp). So we can upgrade tailwindcss to ^3.3.0 and remove this code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished, look again

Copy link
Collaborator

@iamjoel iamjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the tailwind to ^3.3.0 and remove requiring line-clamp in tailwind.config.js

@shunyue1320
Copy link
Contributor Author

Update the tailwind to ^3.3.0 and remove requiring line-clamp in tailwind.config.js

finished, look again

@crazywoola crazywoola requested a review from iamjoel August 3, 2023 01:06
@iamjoel iamjoel merged commit b1b9e3f into langgenius:main Aug 3, 2023
Octivian pushed a commit to Octivian/dify that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants