fix: text copy issue #723
Merged
fix: text copy issue #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes you can do this. I am ok with these changes. |
MatriQ
force-pushed
the
fix/text-copy-issue
branch
from
e4bf9b7 to
0abc919
Compare
crazywoola
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #701
CHANGES:
navigator?.clipboard, it's not supported by all browsers, but the librarycopy-to-clipboardshould be supported by all browsers.writeTextshould be no possible to throw exceptions ( can be verified by reading the source code ofcopy-to-clipboard)TO BE DISCUSSION:
It's unnecessary to use a state to save the copied text and return it from the hook, and there is also nowhere to use it. I even thought there is no need for this hook to exist and we should directly import
copy-to-clipboardand usewriteTextinstead.