Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug desc/copyright/privacy_policy none #796

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix bug desc/copyright/privacy_policy none #796

merged 1 commit into from
Aug 11, 2023

Conversation

lingfengchencn
Copy link
Contributor

orgin code will cause None value,when site description is None, test codes:

site_desc = 'site_desc'
args_desc = 'args_desc'
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

site_desc = None
args_desc = 'args_desc'
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

site_desc = 'site_desc'
args_desc = None
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

site_desc = None
args_desc = None
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

result:

site_desc,args_desc => site_desc
None,args_desc => None
site_desc,None => site_desc
None,None => else_value

@crazywoola crazywoola merged commit d8b712b into langgenius:main Aug 11, 2023
AlanMars added a commit to AlanMars/QYL-dify that referenced this pull request Aug 13, 2023
@AlanMars
Merge branch 'main' of https://github.com/AlanMars/QYL-dify
d9bf6c1 
* 'main' of https://github.com/AlanMars/QYL-dify: (86 commits)
  feat: optimize error raise (langgenius#820)
  fix: completion error when dataset was deleted (langgenius#819)
  feat: frontend remove gpt4 check (langgenius#815)
  only admin and owner can delete app (langgenius#810)
  fix: label (langgenius#809)
  feat: optimize error logging (langgenius#808)
  feat: temp remove paid option of anthropic (langgenius#807)
  Feat/only tag arm64 build (langgenius#806)
  Revert "Fix/disable site when change code" (langgenius#805)
  feat: frontend multi models support (langgenius#804)
  feat: server multi models support (langgenius#799)
  fix bug desc/copyright/privacy_policy none (langgenius#796)
  build: fix .dockerignore file (langgenius#800)
  fix: automatically create tenant for user (langgenius#793)
  feat: add readme (langgenius#791)
  fix: remove ruby from repo due to main gitignore (langgenius#790)
  fix: add missing code (langgenius#788)
  Add Ruby's SDK implement code. (langgenius#786)
  fix i is not incremented due to violating the uniqueness constraint w… (langgenius#771)
  Fix/disable site when change code (langgenius#775)
  ...
@lingfengchencn lingfengchencn deleted the fix/add_recommendedapps branch August 16, 2023 05:53
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
@lingfengchencn
fix bug desc/copyright/privacy_policy none (langgenius#796)
e105817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takatost takatost takatost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lingfengchencn @takatost @crazywoola