Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move testing env variables from pyproject.toml to pytest.ini #9019

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

bowenliang123
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Leaving pyproject.toml focused in project specification declaration, rather than coupling with one-time testing context
  • Use pytest.ini for managing testing env variables, which also benefits for switching pytest.ini versions for different testing scopes in future.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 5, 2024
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Oct 5, 2024

cc @takatost @crazywoola

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@crazywoola crazywoola merged commit b933c9d into langgenius:main Oct 8, 2024
6 checks passed
@bowenliang123 bowenliang123 deleted the pytest-env-standalone branch October 8, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants