Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore the error toast notification if the status is 401 and isPublicAPI is true #9062

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix: Ignore the error toast notification if the status is 401 and isPublicAPI is true #9062

merged 2 commits into from
Oct 8, 2024

Conversation

douxc
Copy link
Collaborator

@douxc douxc commented Oct 8, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Ignore the error toast tip if the code is 'web_sso_auth_requried'

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

@douxc douxc requested a review from GarfieldDai October 8, 2024 03:24
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 8, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 8, 2024
@douxc douxc changed the title fix: ignore the error tip if the code is 'web_sso_auth_required' fix: Ignore the error toast notification if the status is 401 and isPublicAPI is true Oct 8, 2024
GarfieldDai
GarfieldDai approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@GarfieldDai GarfieldDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@douxc douxc merged commit 4abca86 into main Oct 8, 2024
7 checks passed
@douxc douxc deleted the fix/ignore_web_sso_auth_tip branch October 8, 2024 03:48
cuiks pushed a commit to cuiks/dify that referenced this pull request Oct 8, 2024
@douxc @cuiks
fix: Ignore the error toast notification if the status is 401 and isP…
2fc545b 
…ublicAPI is true (langgenius#9062)
@laipz8200 laipz8200 mentioned this pull request Oct 14, 2024
Merged
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@douxc @lau-td
fix: Ignore the error toast notification if the status is 401 and isP…
50bc2f6 
…ublicAPI is true (langgenius#9062)
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@douxc @JunXu01
fix: Ignore the error toast notification if the status is 401 and isP…
37f935e 
…ublicAPI is true (langgenius#9062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarfieldDai GarfieldDai GarfieldDai approved these changes

Assignees
No one assigned
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douxc @GarfieldDai