refactor: move the embedding to the rag module and abstract the rerank runner for extension #9423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
1.Add RerankRunnerFactory and BaseRerankRunner to simplify the creation logic of RerankRunner and enhance extensibility.
2.The core.embedding.cached_embedding depends on core.rag.datasource.entity.embedding, while core.rag.datasource.vdb relies on core.embedding.cached_embedding, creating a circular dependency.
3.Since the cached_embedding in the embedding package is only used by rag, move it to the rag module and reorganize it with the embedding_case module into a new package named embedding. This will make the structure clearer and the functionality more cohesive.
4.Rename embedding_constant to embedding_type. Since this module will be used by both model_runtime and rag, move it to core.entity.
After these changes, the embedding will mainly be used by rag, so moving it to the rag module will result in a clearer directory structure.
Scenario 1: Vector Search
Scenario 2: Hybrid Search
Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration