Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parameters): standardize system parameter field types and values #9797

Merged

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Changed image_file_size_limit from String to Integer in system_parameters_fields.
  • Added video_file_size_limit and audio_file_size_limit with Integer types to system_parameters_fields.
  • Updated system parameter values to use constants from dify_config for image, video, and audio file size limits.

with #9739

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Changed `image_file_size_limit` from String to Integer in `system_parameters_fields`.
- Added `video_file_size_limit` and `audio_file_size_limit` with Integer types to `system_parameters_fields`.
- Updated system parameter values to use constants from `dify_config` for image, video, and audio file size limits.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2024
@crazywoola crazywoola merged commit 22bb041 into main Oct 24, 2024
9 checks passed
@crazywoola crazywoola deleted the feat/standardize-system-parameter-field-types-and-values branch October 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants