Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): Take back LLM streaming output after IF-ELSE #9875

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Removed unnecessary type assignment logic for streamlined processor handling.
  • Simplified checking node types by using direct enum references.
  • Enhanced generator routing by eliminating redundant dictionary iterations.
  • Improved code readability and maintainability with abstract base class refinement.
  • Used Sequence instead of list for type consistency in value selectors.

Fixes #9852

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Removed unnecessary type assignment logic for streamlined processor handling.
- Simplified checking node types by using direct enum references.
- Enhanced generator routing by eliminating redundant dictionary iterations.
- Improved code readability and maintainability with abstract base class refinement.
- Used `Sequence` instead of list for type consistency in value selectors.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 25, 2024
@laipz8200 laipz8200 merged commit 72ea3d6 into main Oct 25, 2024
9 checks passed
@laipz8200 laipz8200 deleted the fix/Take-back-LLM-streaming-output-after-IF-ELSE branch October 25, 2024 14:33
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include branch node stream output not working
2 participants