Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(api): optimize token read/write during api call #9951

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

aconeshana
Copy link

@aconeshana aconeshana commented Oct 28, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  1. Since Dify uses Redis, token authentication can be optimized by storing it in Redis.
  2. Each time a token is used, the last updated timestamp will be refreshed asynchronously via Celery.

Closes #9950

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 28, 2024
@aconeshana
Copy link
Author

related issue: #9950

Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 6, 2024
@aconeshana
Copy link
Author

The following is the benchmark report

env(production):
helm on k8s 4C 32G 4 dify-api instance

benchmark conf

  1. 400 concurrent thread

  2. 2000loop
    image

  3. workflow sse api without llm(Excluding the impact of LLM), input&output
    image

baseline:
image
image
image

new head:
image
image
image

Summary:

  1. Significant reduction in anomaly spike
  2. error rate from 0.11% to 0.08%, mainly due to 502 errors caused by Kubernetes CPU limit
  3. RT reduce

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 6, 2024
crazywoola
crazywoola previously approved these changes Nov 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
crazywoola
crazywoola previously approved these changes Nov 7, 2024
@crazywoola
Copy link
Member

Please resolve the conflict files.

acone added 2 commits November 20, 2024 14:06
…pi-token

# Conflicts:
#	api/extensions/ext_redis.py
#	api/poetry.lock
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api-token use performance enhance
8 participants