Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

#509 feature request 增加favicon #521

Merged
merged 15 commits into from
Sep 29, 2023
Merged

#509 feature request 增加favicon #521

merged 15 commits into from
Sep 29, 2023

Conversation

PythonSmall-Q
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the website This issue or pull request is related to website related files label Sep 29, 2023
@PythonSmall-Q PythonSmall-Q linked an issue Sep 29, 2023 that may be closed by this pull request
[Feature Request] 增加favicon #509
Closed
2 tasks
@langningchen langningchen self-requested a review September 29, 2023 08:25
langningchen
langningchen suggested changes Sep 29, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
xmoj.png Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 29, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 669713d
Status: ✅  Deploy successful!
Preview URL: https://00b18e36.xmoj-script-web.pages.dev
Branch Preview URL: https://509-feature-request---favico.xmoj-script-web.pages.dev

View logs

@PythonSmall-Q
Copy link
Collaborator Author

image
换用相对路径成功出来了favicon @langningchen

@PythonSmall-Q
Copy link
Collaborator Author

哇！cln好棒

@langningchen
Copy link
Owner

哇！cln好棒

Lol

@PythonSmall-Q
Copy link
Collaborator Author

Approveeeee

@langningchen
Copy link
Owner

不是

@langningchen
Copy link
Owner

Darkmode 好像不行

@langningchen
Copy link
Owner

我在看为什么

@PythonSmall-Q
Copy link
Collaborator Author

@langningchen Approve

@langningchen
Copy link
Owner

如果用亮色模式，那个灰色的 ----XMOJ---- 就看不出来了

@PythonSmall-Q
Copy link
Collaborator Author

(?

@PythonSmall-Q
Copy link
Collaborator Author

darkmode(?

@PythonSmall-Q
Copy link
Collaborator Author

那就把那行XMOJ染个色吧

@langningchen
Copy link
Owner

langningchen commented Sep 29, 2023 •
edited
Loading

@PythonSmall-Q 可以，你该图片

@PythonSmall-Q
Copy link
Collaborator Author

@langningchen 等一下，我用ps把favicon的背景白色删掉

@langningchen
Copy link
Owner

让我们看看效果

@langningchen
Copy link
Owner

@PythonSmall-Q 好像ico不支持透明背景

@langningchen
Copy link
Owner

那……要么还是用PNG？

@PythonSmall-Q
Copy link
Collaborator Author

还没好

@PythonSmall-Q
Copy link
Collaborator Author

image
透明了呀

@PythonSmall-Q
Copy link
Collaborator Author

橡皮擦花了半天

@langningchen
Copy link
Owner

@PythonSmall-Q 确实好了

@langningchen
Copy link
Owner

橡皮擦花了半天

你为什么不用魔棒选择工具？

@langningchen langningchen self-requested a review September 29, 2023 08:56
@PythonSmall-Q
Copy link
Collaborator Author

魔棒太烦

langningchen
langningchen suggested changes Sep 29, 2023
View reviewed changes
XMOJ.png Show resolved Hide resolved
@langningchen
Copy link
Owner

LGTM!

@PythonSmall-Q
Copy link
Collaborator Author

Merge！！！

@langningchen langningchen merged commit 4687107 into dev Sep 29, 2023
@PythonSmall-Q PythonSmall-Q deleted the 509-feature-request-增加favicon branch September 29, 2023 09:00
@boomzero boomzero changed the title 509 feature request 增加favicon #509 feature request 增加favicon Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@langningchen langningchen langningchen approved these changes

Assignees
No one assigned
Labels
website This issue or pull request is related to website related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] 增加favicon
2 participants
@PythonSmall-Q @langningchen