Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Fortran test case for getters #85

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nicolasbock
Copy link
Collaborator

@nicolasbock nicolasbock commented Jul 26, 2017

This is a test case for Fortran getters to debug the recent regression in those getters.


This change is Reviewable

@nicolasbock
Copy link
Collaborator Author

@cnegre Please have a look at this PR. It's testing the get_row Fortran API.

@codecov-io
Copy link

Codecov Report

Merging #85 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #85    +/-   ##
======================================
+ Coverage      49%    49%   +<1%     
======================================
  Files         208    208            
  Lines        7909   7909            
  Branches      739    739            
======================================
+ Hits         3919   3920     +1     
  Misses       3882   3882            
+ Partials      108    107     -1
Impacted Files Coverage Δ
src/C-interface/ellpack/bml_scale_ellpack.c 84% <ø> (ø) ⬆️
src/C-interface/ellsort/bml_scale_ellsort.c 84% <ø> (ø) ⬆️
src/C-interface/ellsort/bml_norm_ellsort_typed.c 53% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b124eda...a8045e5. Read the comment docs.

The convert (import) function is working. But the get_row function is
not right now. I don't know at this point how to make the pointer that
comes from the C function into a Fortran array...
@nicolasbock
Copy link
Collaborator Author

@cnegre I have tests now for bml_get_row. They are not integrated yet with the test suite, but they are working locally. The next step here is to add real tests.

@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

Merging #85 into master will decrease coverage by <1%.
The diff coverage is 5%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #85   +/-   ##
=====================================
- Coverage      50%    50%   -1%     
=====================================
  Files         211    211           
  Lines        8116   8129   +13     
  Branches      788    788           
=====================================
+ Hits         4092   4094    +2     
- Misses       3906   3918   +12     
+ Partials      118    117    -1
Impacted Files Coverage Δ
tests/trace_matrix_typed.c 80% <ø> (ø) ⬆️
src/C-interface/dense/bml_convert_dense_typed.c 46% <ø> (ø) ⬆️
src/Fortran-interface/bml_getters_m.F90 0% <0%> (ø) ⬆️
src/Fortran-interface/bml_utilities_m.F90 0% <0%> (ø) ⬆️
src/C-interface/dense/bml_getters_dense_typed.c 100% <100%> (ø) ⬆️
src/C-interface/ellpack/bml_norm_ellpack_typed.c 53% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645b1ee...253dbbd. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the Stale label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants