Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface fix #44

Merged
merged 10 commits into from
Oct 17, 2023
Merged

Interface fix #44

merged 10 commits into from
Oct 17, 2023

Conversation

bnebgen-LANL
Copy link
Collaborator

Improved performance of Lammps interface by executing as float32

Forward compatible ASE interface fix by removing reference to ase.calculators.interface

fixed bug in targes.py using dtype instead of device

added remove_high_properties for ALF compatibility

Nebgen and others added 10 commits March 31, 2023 11:01
    def remove_high_property(self,key,perAtom,species_key=None,cut=None,std_factor=10):
        """
        This function removes outlier data from the dataset
        Must be called before splitting
        "key": the property key in the dataset to check for high values
        "perAtom": True if the property is defined per atom in axis 1, otherwise property is treated as full system
        "std_factor": systems with values larger than this multiplier time the standard deviation of all data will be reomved. None to skip this step
        "cut_factor": systems with values larger than this number are reomved. None to skip this step. This step is done first.
        """
This was causing lammps interfaces not to build correctly.
This causes errors with later versions of ase
lammps: reduce float64 to float32 for speed
ase: remove reference to calculator
@bnebgen-LANL
Copy link
Collaborator Author

Confirmed working.

@bnebgen-LANL bnebgen-LANL merged commit 894beb5 into development Oct 17, 2023
0 of 2 checks passed
adela-habib added a commit to adela-habib/hippynn that referenced this pull request Oct 18, 2023
@bnebgen-LANL bnebgen-LANL deleted the interface_fix branch October 24, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants