Fix some typing and docstring issues #223
Conversation
bwohlberg
added
documentation
scico/examples.py
Outdated
| """ | ||
|
|
||
| if center == None: | ||
| if center is None: | ||
| center = [img_dim // 2 for img_dim in img_shape] |
There was a problem hiding this comment.
Is the intent here really to only support integer center values? If not, this should be ... img_dim / 2 ....
There was a problem hiding this comment.
Yes, I originally thought of only integer values. But making it floats (/ instead of //) would be more general and should work.
scico/examples.py
Outdated
| img_shape: Shape of the phantom to be created. | ||
| radius_list: List of radii of the rings in the phantom. | ||
| val_list: List of intensity values of the rings in the phantom. | ||
| center: Tuple of center pixel ids. If ``None``, this is set to |
There was a problem hiding this comment.
What are "ids" in "center pixel ids"? Perhaps this was intended to be "center pixel indices"?
There was a problem hiding this comment.
Yes, by ids I meant indices.
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 49 49
Lines 3431 3431
=======================================
Hits 3171 3171
Misses 260 260
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fix some typing and docstring issues.