Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fix #266

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Misc bug fix #266

merged 3 commits into from
Mar 25, 2022

Conversation

smajee
Copy link
Contributor

@smajee smajee commented Mar 25, 2022

  • Add missing bm4d notebook

  • Improve svmbir tests

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #266 (e3ab4fb) into main (f0758ea) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   93.72%   93.83%   +0.10%     
==========================================
  Files          50       50              
  Lines        3681     3681              
==========================================
+ Hits         3450     3454       +4     
+ Misses        231      227       -4     
Flag Coverage Δ
unittests 93.83% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/radon_svmbir.py 86.84% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0758ea...e3ab4fb. Read the comment docs.

@smajee smajee requested a review from bwohlberg March 25, 2022 20:53
Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please make a note that the new notebook should, at some point, be rebuilt on a host with GPUs (or with the environment variable set to avoid the WARNING:absl:No GPU/TPU found, falling back to CPU. (Set TF_CPP_MIN_LOG_LEVEL=0 and rerun for more info.) warning), but that needn't delay merging this PR.

@smajee
Copy link
Contributor Author

smajee commented Mar 25, 2022

Looks good. Please make a note that the new notebook should, at some point, be rebuilt on a host with GPUs (or with the environment variable set to avoid the WARNING:absl:No GPU/TPU found, falling back to CPU. (Set TF_CPP_MIN_LOG_LEVEL=0 and rerun for more info.) warning), but that needn't delay merging this PR.

OK. Sounds good.

@smajee smajee merged commit 70be677 into main Mar 25, 2022
@smajee smajee deleted the smajee/bug-fix branch March 25, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants