-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce test run time #275
Reduce test run time #275
Conversation
Codecov Report
@@ Coverage Diff @@
## main #275 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 51 51
Lines 3696 3696
=======================================
Hits 3469 3469
Misses 227 227
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- os: ubuntu-latest | ||
label: linux-64 | ||
prefix: /usr/share/miniconda3/envs/test-env | ||
- os: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this double the time tests take? I would consider mac compatibility issues to be relatively unimportant, maybe worth a weekly/monthly test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they run in parallel. I agree the OSX tests aren't as important, but they do have some value -- for example, adding these tests here immediately revealed some deficiencies in a previous attempt to make bm3d
an optional dependency.
Attempt to reduce test run time.