Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test run time #275

Merged
merged 31 commits into from
Apr 12, 2022
Merged

Reduce test run time #275

merged 31 commits into from
Apr 12, 2022

Conversation

bwohlberg
Copy link
Collaborator

Attempt to reduce test run time.

@bwohlberg bwohlberg added the tests Pertaining to SCICO tests label Apr 10, 2022
@bwohlberg bwohlberg marked this pull request as draft April 10, 2022 00:09
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #275 (989742d) into main (b37a72c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files          51       51           
  Lines        3696     3696           
=======================================
  Hits         3469     3469           
  Misses        227      227           
Flag Coverage Δ
unittests 93.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/radon_svmbir.py 85.96% <0.00%> (-0.88%) ⬇️
scico/loss.py 94.82% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37a72c...989742d. Read the comment docs.

@bwohlberg bwohlberg marked this pull request as ready for review April 12, 2022 01:04
- os: ubuntu-latest
label: linux-64
prefix: /usr/share/miniconda3/envs/test-env
- os: macos-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this double the time tests take? I would consider mac compatibility issues to be relatively unimportant, maybe worth a weekly/monthly test.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they run in parallel. I agree the OSX tests aren't as important, but they do have some value -- for example, adding these tests here immediately revealed some deficiencies in a previous attempt to make bm3d an optional dependency.

@bwohlberg bwohlberg merged commit e32a106 into main Apr 12, 2022
@bwohlberg bwohlberg deleted the brendt/tests branch April 12, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pertaining to SCICO tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants