Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Operator and LinearOperator module structure #329

Merged
merged 23 commits into from
Sep 2, 2022
Merged

Clean up Operator and LinearOperator module structure #329

merged 23 commits into from
Sep 2, 2022

Conversation

bwohlberg
Copy link
Collaborator

Clean up Operator and LinearOperator module structure.

@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022 •
edited
Loading

Codecov Report

Merging #329 (3b55dbd) into main (72b30ba) will increase coverage by 0.07%.
The diff coverage is 94.27%.

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   93.88%   93.95%   +0.07%     
==========================================
  Files          55       58       +3     
  Lines        3451     3493      +42     
==========================================
+ Hits         3240     3282      +42     
  Misses        211      211
Flag Coverage Δ
unittests 93.95% <94.27%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/_diff.py 98.30% <ø> (ø)
scico/linop/optics.py 99.20% <ø> (ø)
scico/linop/radon_astra.py 62.16% <ø> (ø)
scico/numpy/_wrappers.py 97.10% <ø> (ø)
scico/linop/_stack.py 87.64% <33.33%> (ø)
scico/linop/_linop.py 91.86% <90.99%> (-6.23%) ⬇️
scico/operator/_operator.py 93.22% <93.22%> (ø)
scico/linop/_diag.py 96.36% <96.36%> (ø)
scico/linop/__init__.py 100.00% <100.00%> (ø)
scico/linop/_circconv.py 84.61% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwohlberg bwohlberg mentioned this pull request Aug 31, 2022
Closed
@bwohlberg bwohlberg linked an issue Aug 31, 2022 that may be closed by this pull request
Missing or inadequate docs in scico._generic_operators module #319
Closed
@bwohlberg bwohlberg mentioned this pull request Sep 1, 2022
Closed
Michael-T-McCann
Michael-T-McCann approved these changes Sep 1, 2022
View reviewed changes
scico/linop/_misc.py.BAK Outdated
@@ -0,0 +1,219 @@
# Copyright (C) 2020-2022 by SCICO Developers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file meant to be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! Good catch, thanks. Not sure how that sneaked in there.

This was linked to issues Sep 2, 2022
Add a padding linop #231
Closed
Add Reshape linop #312
Closed
@bwohlberg bwohlberg merged commit 88026d2 into main Sep 2, 2022
@bwohlberg bwohlberg deleted the brendt/operator branch September 2, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-T-McCann Michael-T-McCann Michael-T-McCann approved these changes

Assignees
No one assigned
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing or inadequate docs in scico._generic_operators module Add Reshape linop Add a padding linop
2 participants
@bwohlberg @Michael-T-McCann