-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for computing prox of convex conjugate of functional #33
Conversation
def prox(self, x: Union[JaxArray, BlockArray], lam: float) -> Union[JaxArray, BlockArray]: | ||
r"""Evaluate proximal mapping at point :math:`\mb{x}` with scaling lam | ||
def prox(self, x: Union[JaxArray, BlockArray], lam: float = 1) -> Union[JaxArray, BlockArray]: | ||
r"""Scaled proximal operator of functional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"scaled proximal operator" sounds to me like c * prox_f. How about "proximal operator of optionally scaled functional". Or simply "Proximal operator of functional" and just make the scaling explicit in the formula.
def prox(self, x: Union[JaxArray, BlockArray], lam: float = 1) -> Union[JaxArray, BlockArray]: | ||
r"""Scaled proximal operator of functional. | ||
|
||
Evaluate scaled proximal operator of this functional, with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see again my comment on "scaled proximal operator"
Add method for computing prox of convex conjugate of functional.
The code is straightforward, but others may have different ideas on naming of the method, for example.