Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #152 #351

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Resolve #152 #351

merged 4 commits into from
Oct 10, 2022

Conversation

bwohlberg
Copy link
Collaborator

Resolve #152.

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #351 (a71fc9e) into main (817e184) will increase coverage by 0.13%.
The diff coverage is 50.60%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   93.96%   94.10%   +0.13%     
==========================================
  Files          58       56       -2     
  Lines        3499     3361     -138     
==========================================
- Hits         3288     3163     -125     
+ Misses        211      198      -13     
Flag Coverage Δ
unittests 94.10% <50.60%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/_flax.py 96.92% <0.00%> (ø)
scico/examples.py 96.00% <ø> (ø)
scico/functional/_functional.py 92.95% <ø> (ø)
scico/linop/_circconv.py 84.61% <0.00%> (ø)
scico/linop/_dft.py 100.00% <ø> (ø)
scico/linop/radon_astra.py 62.16% <0.00%> (ø)
scico/linop/radon_svmbir.py 86.32% <0.00%> (ø)
scico/numpy/_blockarray.py 97.43% <0.00%> (ø)
scico/numpy/_wrappers.py 97.10% <ø> (ø)
scico/optimize/_admm.py 97.41% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


1. Add the ``new_data.npz`` file to the ``scico/data`` directory.
2. Add the ``new_data.npz`` file to the appropriate subdirectory (creating a new one if necessary) of thee ``scico/data`` directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thee sounds too archaic ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

@bwohlberg bwohlberg merged commit 605ba76 into main Oct 10, 2022
@bwohlberg bwohlberg deleted the brendt/issue#152 branch October 10, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation section Contributing in need of some attention
2 participants