Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADMM subproblem solver for matrix operators #426

Merged
merged 38 commits into from
Jun 16, 2023
Merged

Conversation

bwohlberg
Copy link
Collaborator

@bwohlberg bwohlberg commented Jun 14, 2023

Add ADMM subproblem solver for matrix operators, addressing one of the remaining components of #232.

Also:

  • Clean up implementations of block convolution subproblem solvers.
  • Improvements to Diagonal linop.
  • Minor fixes to docs and exception types.
  • Add two utility functions.

@bwohlberg bwohlberg added the enhancement New feature or request label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #426 (a7843e8) into main (894f8b3) will increase coverage by 0.08%.
The diff coverage is 94.86%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   94.78%   94.86%   +0.08%     
==========================================
  Files          86       86              
  Lines        5309     5426     +117     
==========================================
+ Hits         5032     5147     +115     
- Misses        277      279       +2     
Flag Coverage Δ
unittests 94.86% <94.86%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/_matrix.py 96.00% <ø> (ø)
scico/optimize/_admm.py 96.00% <ø> (ø)
scico/optimize/admm.py 100.00% <ø> (ø)
scico/optimize/_admmaux.py 96.81% <89.36%> (+1.50%) ⬆️
scico/solver.py 97.40% <95.40%> (-1.26%) ⬇️
scico/linop/_diag.py 97.62% <100.00%> (+1.26%) ⬆️
scico/util.py 92.95% <100.00%> (+0.48%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions.

scico/optimize/_admmaux.py Outdated Show resolved Hide resolved
scico/solver.py Outdated Show resolved Hide resolved
scico/solver.py Show resolved Hide resolved
scico/solver.py Show resolved Hide resolved
scico/solver.py Outdated Show resolved Hide resolved
scico/solver.py Show resolved Hide resolved
@Michael-T-McCann Michael-T-McCann merged commit 5c7f6ba into main Jun 16, 2023
@Michael-T-McCann Michael-T-McCann deleted the brendt/solver branch June 16, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants