Fixed SSLCertificate Error in Get_URL #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent due to certificate errors. Changed link to a smaller sized link hosted on github for easier access.
bwohlberg
reviewed
Oct 22, 2021
| def test_url_get(): | ||
| url = "https://webpages.tuni.fi/foi/GCF-BM3D/BM3D_TIP_2007.pdf" | ||
| assert not url_get(url).getvalue().find(b"bm3d") == -1 | ||
| url = "https://github.com/lanl/scico/blob/main/README.rst" |
There was a problem hiding this comment.
Shouldn't the test URL on line 51 also be changed?
bwohlberg
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL was failing to retrieve the document due to certificate errors. Changed link to a smaller-sized link hosted on GitHub for easier access.