Refactor radio button to use value container #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhou121
reviewed
Jan 25, 2024
| { | ||
| radio_button_svg(represented_value, actual_value).keyboard_navigatable() | ||
| let (inbound_signal, outbound_signal) = create_value_container_signals(actual_value); |
There was a problem hiding this comment.
I think we should make the T in create_value_container_signals Clone rather than Copy.
There was a problem hiding this comment.
Done. I kept the Copy of the T in the radio button functions though, since I have to move a copy of represented_value into a closure there.
There was a problem hiding this comment.
You can create a clone for it as well. Copy is just so strict here.
e.g.
let local_represented_value = represented_value.clone();
value_container(
radio_button_svg(represented_value, inbound_signal.read_only())
.keyboard_navigatable()
.on_click_stop(move |_| {
outbound_signal.set(local_represented_value.clone());
}),
move || outbound_signal.get(),
)
There was a problem hiding this comment.
Hmm, I didn't realize Rust treated a let differently than a function parameter. Thanks for the tip, I think I fixed it.
pieterdd
force-pushed
the
port-radio-button
branch
2 times, most recently
from
3b48b44 to
ac41434
Compare
pieterdd
force-pushed
the
port-radio-button
branch
from
ac41434 to
eaf455f
Compare
jrmoulton
pushed a commit
to jrmoulton/floem
that referenced
this pull request
Feb 2, 2024
* Replace Copy with Clone * Refactor radio button to use value container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.