Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue for quote #47

Merged
merged 3 commits into from
Apr 30, 2016
Merged

Fix an issue for quote #47

merged 3 commits into from
Apr 30, 2016

Conversation

Cokile
Copy link
Contributor

@Cokile Cokile commented Apr 22, 2016

  1. Parser now can parse multiple paragraph correctly.
  2. Change the style of quote so it is easy to be distinguished from common
    text.

1. Parser now can parse multiple paragraph correctly.

2. Change the style of quote so it is easy to  distinguish from common
text
@Cokile
Copy link
Contributor Author

Cokile commented Apr 22, 2016

Here is the comparison of markdown quote example:
screen shot 2016-04-22 at 08 52 28

Before:
before

After:
after

@Coeur
Copy link
Collaborator

Coeur commented Apr 22, 2016

Thank you Cokile.

But requirements for TSMarkdownQuoteRegex is to have a space on third line of your example. If you want to make spaces optional, then you should use TSMarkdownShortQuoteRegex.

@Cokile
Copy link
Contributor Author

Cokile commented Apr 25, 2016

@Coeur TSMarkdownShortQuoteRegex works for my example.

Anyway, only for your reference, you should use another font for quote text for a better user experience.

@Coeur Coeur merged commit da3aea3 into laptobbe:master Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants