Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed VirusTotal module #1172

Merged
merged 10 commits into from
Aug 6, 2022
Merged

Fixed VirusTotal module #1172

merged 10 commits into from
Aug 6, 2022

Conversation

NotoriousRebel
Copy link
Collaborator

Fixed VirusTotal module to use v3 of the API to find subdomains.

@L1ghtn1ng L1ghtn1ng merged commit c801db6 into laramies:master Aug 6, 2022
# them and submit a PR or raise an issue if you run into this filtering not being enough
# TODO determine if parsing 'v=spf1 include:_spf-x.acme.com include:_spf-x.acme.com' is worth parsing
total_subdomains = [x for x in total_subdomains if
not str(x).endswith('edgekey.net') and not str(x).endswith('akadns.net')

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[edgekey.net](1)' may be at an arbitrary position in the sanitized URL.
# them and submit a PR or raise an issue if you run into this filtering not being enough
# TODO determine if parsing 'v=spf1 include:_spf-x.acme.com include:_spf-x.acme.com' is worth parsing
total_subdomains = [x for x in total_subdomains if
not str(x).endswith('edgekey.net') and not str(x).endswith('akadns.net')

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[akadns.net](1)' may be at an arbitrary position in the sanitized URL.
@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2022

This pull request introduces 2 alerts when merging 263fd71 into 121e23b - view on LGTM.com

new alerts:

  • 2 for Incomplete URL substring sanitization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants