-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MyPy CI failures #1488
Merged
Merged
MyPy CI failures #1488
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
44c7b12
black and isort formatting
yoonthegoon 26a1fa6
#1383 fix stash.py
yoonthegoon 684c7c2
#1383 #1486 fix screenshot.py
yoonthegoon 081ce57
#1383 fix censysearch.py
yoonthegoon 0d0a9f0
#1383 fix bingsearch.py
yoonthegoon 31bacdf
#1383 fix core.py
yoonthegoon fef8396
#1383 fix takeover.py
yoonthegoon 25fe4ab
#1383 fix takeover.py
yoonthegoon 805a502
#1383 improved readability
yoonthegoon 2351c88
#1383 fix dnsdumpster.py
yoonthegoon 7475924
#1383 fix constants.py
yoonthegoon 2579d60
#1383 #1487 fix zoomeyesearch.py
yoonthegoon 5db041c
#1383 fix securitytrailssearch.py
yoonthegoon 0706579
#1383 fix intelxsearch.py
yoonthegoon 0b371c5
#1383 assign self.info typing
yoonthegoon b9af76f
#1383 need figure out `page_from_response` method
yoonthegoon 0ac1eda
add ignore E203 and W503
yoonthegoon 8d61aef
Clear-text logging of sensitive information
yoonthegoon 8f7dd9d
remove import shadowed by loop variable
yoonthegoon b7aba8e
add flake8 config flag
yoonthegoon 8468e47
#1383 fix githubcode.py
yoonthegoon 4d0f9a5
Clear-text logging of sensitive information
yoonthegoon 3aa25f6
#1383 fix __main__.py
yoonthegoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
[flake8] | ||
ignore = E501, F405, F403, F401, E402 | ||
ignore = E203, E501, F405, F403, F401, E402, W503 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from theHarvester.discovery import *
already exists at the top of the file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some times it's needed as it does not actually work without that, if you tested it and it still works then am happy for it to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it out myself after making this change yet, only ran
pytest
after. I'll give it a shot tomorrow. There's still more I've got to go through it looks like.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMK if you got a command I can run that results in some vhosts. I tried a few stuff with keeping and removing the import, but both resulsts didn't have any vhosts to show. I can experiment with harvesting more a bit later.