bail out on translation save if parent save failed

laraplus · Mar 16, 2017 · 116c64c · 116c64c
1 parent 5c2c431
commit 116c64c
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/Translatable.php b/src/Translatable.php
@@ -40,9 +40,7 @@ public static function create(array $attributes = [], $translations = [])
     {
         $model = new static($attributes);
 
-        $model->save();
-
-        if(is_array($translations)) {
+        if($model->save() && is_array($translations)) {
             $model->saveTranslations($translations);
         }
 
@@ -59,11 +57,9 @@ public static function create(array $attributes = [], $translations = [])
      */
     public static function createInLocale($locale, array $attributes = [], $translations = [])
     {
-        $model = new static($attributes);
-
-        $model->setLocale($locale)->save();
+        $model = (new static($attributes))->setLocale($locale);
 
-        if(is_array($translations)) {
+        if($model->save() && is_array($translations)) {
             $model->saveTranslations($translations);
         }