-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/matches ids ulid #12
Feat/matches ids ulid #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR - looks like a good thing to add! Can you back out the change to the .gitignore
? Ignoring IDE folders I'd expect in a global gitignore, not the project one.
Also, can you confirm where you got the regex for the ULID? Just so I can check it before merging and tagging.
I put information in the description. Like I said I didn't found an "official" regex for the ULID. https://chat.openai.com/share/e9555822-4ffb-4845-8e40-0bc6cbbc658d |
@Ashk2a thanks for the info about the regex- sorry I missed that in your original message. I think we should match what Laravel does for route regexes for ULIDs. Looking at this docs: There's a Can you match the regex in your PR to the Laravel one? Sorry for the back and forth on this - only had time to look at the regex this evening. This is a great addition, so thanks for your time with it - I'm just making sure it's definitely right before merging! |
Thanks, very good idea to check Laravel directly! |
Summary
Add possibility to match ULID route key.
FYI
whereUlid
method when defining routes.