feat: support Illuminate\Auth\Access\Response from authorizer #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haddowg I've just tagged |
haddowg
force-pushed
the
feat/authorizer-response
branch
from
26f46bd to
8a6b0d3
Compare
@lindyhopchris updated |
|
@haddowg one final change required, you'll need to swap the |
|
Actually, might be best to put it to |
haddowg
force-pushed
the
feat/authorizer-response
branch
4 times, most recently
from
ab45f5c to
76bfdb6
Compare
haddowg
force-pushed
the
feat/authorizer-response
branch
from
76bfdb6 to
29b8ac7
Compare
|
done |
lindyhopchris
approved these changes
Dec 1, 2024
| */ | ||
| public function authorizeResource(Authorizer $authorizer): bool | ||
| public function authorizeResource(Authorizer $authorizer): bool|Response |
There was a problem hiding this comment.
This change is technically breaking. As the method is public, anyone could be calling it - and if they're relying on it returing a boolean it'll break their implementation.
So I'll need to tag this as a major release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on laravel-json-api/core#19 and adds support for gates and policies with Illuminate\Auth\Access\Response return values.
I have not modified the composer.json to pull this branch from core but have tested it with it locally.