Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add a conditional separation between showRelated and showRelationship #93

Closed

Conversation

Mina-R-Meshriky
Copy link

regarding issue laravel-json-api/core#6
if method showRelated exists in the custom authorizer, the two relationship-routes :
/api/resource/{resource_id}/relatedResource
/api/resource/{resource_id}/relationships/relatedResource

will authorize differently

…lationship auth methods if showRelated exists
@Mina-R-Meshriky Mina-R-Meshriky changed the title [feature] add a conditional separation between showRelated and showRelationship in Authorizer [feature] add a conditional separation between showRelated and showRelationship Jun 18, 2021
@lindyhopchris
Copy link
Contributor

Thanks for submitting this. However the intent was to add the showRelated method to the authorizer interface.

I've now done that, so closing this PR in favour of 1f12602

Would be useful if you could try out the changes. To do this:

composer require laravel-json-api/laravel:dev-develop --no-update
composer up laravel-json-api/*

@Mina-R-Meshriky
Copy link
Author

@lindyhopchris I tested it and it works as expected 👍👍

@lindyhopchris
Copy link
Contributor

Great, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants