Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make routeNotificationFor method accepts notification object #28

Merged
merged 1 commit into from
May 11, 2020
Merged

make routeNotificationFor method accepts notification object #28

merged 1 commit into from
May 11, 2020

Conversation

ahmedsayedabdelsalam
Copy link
Contributor

I have a situation that I want to check the notification type in the routeNotificationFor() method

@atymic atymic merged commit deea690 into laravel-notification-channels:master May 11, 2020
@atymic
Copy link
Member

atymic commented May 11, 2020

Thanks for the PR!

@ahmedsayedabdelsalam
Copy link
Contributor Author

My pleasure :)

@atymic
Copy link
Member

atymic commented May 11, 2020

@chrisbjr would you like to tag a new release when you get a chance? :)

@chrisbjr
Copy link
Collaborator

Thanks @atymic! Will tag soon, will probably wait for the other PR #29 so I can tag a minor release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedsayedabdelsalam @atymic @chrisbjr