Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass notification instance to routeNotificationFor call #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

klaasgeldof
Copy link

@klaasgeldof klaasgeldof commented Mar 14, 2023

You can pass the notification instance to the routeNotificationFor call, so you can do this in your User model:

public function routeNotificationForMessagebird(Notification $notification)
{
    //
}

Previously, null was always passed to this method.

There was also a deprecation warning from PHP about the creation of dynamic properties.

@klaasgeldof
Copy link
Author

Can someone have a look at this? It's a really simple PR. Thanks!

@ufukseyithan
Copy link

I'm surprised this has still not been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants