Handle missing URL scheme

laravel-shift · Oct 11, 2022 · b979027 · b979027
1 parent 1b85da7
commit b979027
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/src/Models/Request.php b/src/Models/Request.php
@@ -173,7 +173,7 @@ private static function parseData(array $data): array
 
     private static function buildUrl(array $url): string
     {
-        $output = $url['scheme'] . '://' . $url['host'];
+        $output = ($url['scheme'] ?? 'https') . '://' . ($url['host'] ?? '');
 
         if (isset($url['port'])) {
             $output .= ':' . $url['port'];

diff --git a/tests/Feature/Console/Commands/CurlCommandTest.php b/tests/Feature/Console/Commands/CurlCommandTest.php
@@ -41,6 +41,7 @@ public function curlCommandFixtures()
             'Initial connection timeout' => ['connect-timeout'],
             'Entire transaction timeout' => ['max-timeout'],
             'Ignore location flag' => ['ignore-location-flag'],
+            'Missing URL scheme' => ['missing-url-scheme'],
         ];
     }
 

diff --git a/tests/fixtures/missing-url-scheme.in b/tests/fixtures/missing-url-scheme.in
@@ -0,0 +1 @@
+curl -X POST -d 'foo=bar' example.com
diff --git a/tests/fixtures/missing-url-scheme.out b/tests/fixtures/missing-url-scheme.out
@@ -0,0 +1,4 @@
+Http::asForm()
+    ->post('https://example.com', [
+        'foo' => 'bar',
+    ]);