Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--location (follow redirects) is not necessary with Http client; what to do? #10

Closed
nexxai opened this issue Oct 11, 2022 · 4 comments · Fixed by #11
Closed

--location (follow redirects) is not necessary with Http client; what to do? #10

nexxai opened this issue Oct 11, 2022 · 4 comments · Fixed by #11

Comments

@nexxai
Copy link
Contributor

nexxai commented Oct 11, 2022

Just wondering how you want to handle the --location flag. With cURL, it means "follow any redirects" but the Laravel Http client does this by default.

My thinking is to just silently accept and discard it so that it doesn't throw an error like this:

Screen Shot 2022-10-11 at 10 39 23 AM

Thoughts? I'm happy to add this "feature" if you're ok with the idea of just ignoring it.

@jasonmccreary
Copy link
Collaborator

Sure. Could just add the option to the command and do nothing with it. 👍

@nexxai
Copy link
Contributor Author

nexxai commented Oct 11, 2022

Yeah, that's what I was going to do. Will send a PR shortly. Thanks JMac :)

@jasonmccreary
Copy link
Collaborator

@nexxai, awesome! Throw in a quick test if you don't mind. Just to demonstrate it does nothing.

@nexxai
Copy link
Contributor Author

nexxai commented Oct 11, 2022

Consider it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants