Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cURL's --location flag #11

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Ignore cURL's --location flag #11

merged 3 commits into from
Oct 11, 2022

Conversation

nexxai
Copy link
Contributor

@nexxai nexxai commented Oct 11, 2022

Closes #10

When the --location or -L shortcut is given to follow redirects, it is silently dropped since this is the default Http client behaviour.

@jasonmccreary
Copy link
Collaborator

This is good. However, I would appreciate if you could make a test fixture and add it to the data provider (instead of a new test case).

Basically you create a .in file with the expected curl command and then a .out file of the same name with the Http client code.

In this case, you'd have a curl command with the --location option and Http code that doesn't have any extra options/methods than normal.

@nexxai
Copy link
Contributor Author

nexxai commented Oct 11, 2022

Sorry about that. Fixture created.

@jasonmccreary jasonmccreary merged commit 1b85da7 into laravel-shift:main Oct 11, 2022
@jasonmccreary
Copy link
Collaborator

Epic. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--location (follow redirects) is not necessary with Http client; what to do?
2 participants