Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] Register webhook route with the package #672

Merged
merged 2 commits into from
May 20, 2019
Merged

Conversation

driesvints
Copy link
Member

This commit auto-registers the webhook endpoint with the package so the user doesn't has to do this themselves. They can still override it in their own routes file. Benefit of this is also that our integration test is now an actual endpoint test.

In an upcoming PR another route for payment intents will be added.

This commit auto-registers the webhook endpoint with the package so the user doesn't has to do this themselves. They can still override it in their own routes file. Benefit of this is also that our integration test is now an actual endpoint test.
@taylorotwell
Copy link
Member

I think you may want to do stuff that other providers that register routes do like check if routes are already cached.

@driesvints
Copy link
Member Author

@taylorotwell good spot. I actually went through the service provider a bit to clean it up. I've also implemented the routes now in the same way as Horizon. It now makes use of the loadRoutesFrom method.

@taylorotwell taylorotwell merged commit b37e0dc into master May 20, 2019
@driesvints driesvints deleted the register-routes branch May 20, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants