[1.x] Explode argument option issue losing a part of the argument when multiple = in one line is used #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a limit to the explode of the argument to prevent losing a part of the argument when for example passing a url with query parameters with multiple = values in the argument value.
When passing a URL with query parameters as argument to Envoy, currently it explodes the = value which then is filled back in to the $options array. But by doing this, it losses argument values which has got more than 1 = statement in the argument value.
So for example the following command currently will result in this.
currently results into:
http://domain.com?key
instead of what it should be:
http://domain.com?key=value
So by adding a limit to the following explode
Currently:
New:
which results in maintaining additional = values in the argument.
http://domain.com?key=value
I have unit tested the current tests and it succeeded, i don't think it will be a issue updating this as the current arguments are still in tact and no changes are made in that.