revert circular dep

laravel · Mar 16, 2021 · 332844e · 332844e
1 parent 9f986ce
commit 332844e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/Illuminate/Container/Container.php b/src/Illuminate/Container/Container.php
@@ -842,9 +842,9 @@ public function build($concrete)
             return $this->notInstantiable($concrete);
         }
 
-        if (in_array($concrete, $this->buildStack)) {
-            throw new CircularDependencyException("Circular dependency detected while resolving [{$concrete}].");
-        }
+        // if (in_array($concrete, $this->buildStack)) {
+        //     throw new CircularDependencyException("Circular dependency detected while resolving [{$concrete}].");
+        // }
 
         $this->buildStack[] = $concrete;
 

diff --git a/tests/Container/ContainerTest.php b/tests/Container/ContainerTest.php
@@ -564,13 +564,13 @@ public function testContainerCanResolveClasses()
         $this->assertInstanceOf(ContainerConcreteStub::class, $class);
     }
 
-    public function testContainerCanCatchCircularDependency()
-    {
-        $this->expectException(CircularDependencyException::class);
+    // public function testContainerCanCatchCircularDependency()
+    // {
+    //     $this->expectException(CircularDependencyException::class);
 
-        $container = new Container;
-        $container->get(CircularAStub::class);
-    }
+    //     $container = new Container;
+    //     $container->get(CircularAStub::class);
+    // }
 }
 
 class CircularAStub