prevent calling tries twice (#53010)

laravel · Oct 2, 2024 · 60c2ba9 · 60c2ba9
1 parent 46dc7a4
commit 60c2ba9
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/Illuminate/Queue/Queue.php b/src/Illuminate/Queue/Queue.php
@@ -143,7 +143,7 @@ protected function createObjectPayload($job, $queue)
             'uuid' => (string) Str::uuid(),
             'displayName' => $this->getDisplayName($job),
             'job' => 'Illuminate\Queue\CallQueuedHandler@call',
-            'maxTries' => $this->getJobTries($job) ?? null,
+            'maxTries' => $this->getJobTries($job),
             'maxExceptions' => $job->maxExceptions ?? null,
             'failOnTimeout' => $job->failOnTimeout ?? false,
             'backoff' => $this->getJobBackoff($job),
@@ -191,13 +191,11 @@ public function getJobTries($job)
             return;
         }
 
-        if (isset($job->tries)) {
-            return $job->tries;
+        if (is_null($tries = $job->tries ?? $job->tries())) {
+            return;
         }
 
-        if (method_exists($job, 'tries') && ! is_null($job->tries())) {
-            return $job->tries();
-        }
+        return $tries;
     }
 
     /**