[11.x] remove temporary variables (#53810)

* remove simple temporary variables

the declared variable is only used once. inlining does not decrease readability.

my guess is it was originally written this way *before* we had arrow functions, and could inherit the outer `$this` scope.

also minor formatting update to use our new multiline chaining standard

* revert

* inline some more simple variables

also put each argument on separate line for multiline for better git diffs

* remove more temporary variables

a couple more real simple ones

src/Illuminate/Auth/Access/Gate.php

@@ -836,12 +836,14 @@ protected function formatAbilityToMethod($ability)
      */
     public function forUser($user)
     {
-        $callback = fn () => $user;
-
         return new static(
-            $this->container, $callback, $this->abilities,
-            $this->policies, $this->beforeCallbacks, $this->afterCallbacks,
-            $this->guessPolicyNamesUsingCallback
+            $this->container,
+            fn () => $user,
+            $this->abilities,
+            $this->policies,
+            $this->beforeCallbacks,
+            $this->afterCallbacks,
+            $this->guessPolicyNamesUsingCallback,
         );
     }
 

src/Illuminate/Auth/AuthManager.php

@@ -122,11 +122,9 @@ protected function callCustomCreator($name, array $config)
      */
     public function createSessionDriver($name, $config)
     {
-        $provider = $this->createUserProvider($config['provider'] ?? null);
-
         $guard = new SessionGuard(
             $name,
-            $provider,
+            $this->createUserProvider($config['provider'] ?? null),
             $this->app['session.store'],
             rehashOnLogin: $this->app['config']->get('hashing.rehash_on_login', true),
         );

src/Illuminate/Auth/CreatesUserProviders.php

@@ -63,9 +63,11 @@ protected function getProviderConfiguration($provider)
      */
     protected function createDatabaseProvider($config)
     {
-        $connection = $this->app['db']->connection($config['connection'] ?? null);
-
-        return new DatabaseUserProvider($connection, $this->app['hash'], $config['table']);
+        return new DatabaseUserProvider(
+            $this->app['db']->connection($config['connection'] ?? null),
+            $this->app['hash'],
+            $config['table'],
+        );
     }
 
     /**

src/Illuminate/Foundation/Concerns/ResolvesDumpSource.php

@@ -165,13 +165,11 @@ protected function resolveSourceHref($file, $line)
             $file = str_replace($this->basePath, $basePath, $file);
         }
 
-        $href = str_replace(
+        return str_replace(
             ['{file}', '{line}'],
             [$file, is_null($line) ? 1 : $line],
             $href,
         );
-
-        return $href;
     }
 
     /**

src/Illuminate/Http/Request.php

@@ -224,9 +224,8 @@ public function segments()
      */
     public function is(...$patterns)
     {
-        $path = $this->decodedPath();
-
-        return (new Collection($patterns))->contains(fn ($pattern) => Str::is($pattern, $path));
+        return (new Collection($patterns))
+            ->contains(fn ($pattern) => Str::is($pattern, $this->decodedPath()));
     }
 
     /**
@@ -248,9 +247,8 @@ public function routeIs(...$patterns)
      */
     public function fullUrlIs(...$patterns)
     {
-        $url = $this->fullUrl();
-
-        return (new Collection($patterns))->contains(fn ($pattern) => Str::is($pattern, $url));
+        return (new Collection($patterns))
+            ->contains(fn ($pattern) => Str::is($pattern, $this->fullUrl()));
     }
 
     /**

src/Illuminate/Queue/DatabaseQueue.php

@@ -320,10 +320,12 @@ protected function isReservedButExpired($query)
      */
     protected function marshalJob($queue, $job)
     {
-        $job = $this->markJobAsReserved($job);
-
         return new DatabaseJob(
-            $this->container, $this, $job, $this->connectionName, $queue
+            $this->container,
+            $this,
+            $this->markJobAsReserved($job),
+            $this->connectionName,
+            $queue,
         );
     }
 

src/Illuminate/Routing/Console/ControllerMakeCommand.php

@@ -136,11 +136,9 @@ protected function buildClass($name)
             $replace["use {$rootNamespace}Http\Controllers\Controller;\n"] = '';
         }
 
-        $class = str_replace(
+        return str_replace(
             array_keys($replace), array_values($replace), parent::buildClass($name)
         );
-
-        return $class;
     }
 
     /**

tests/Foundation/Testing/Traits/CanConfigureMigrationCommandsTest.php

@@ -17,12 +17,10 @@ protected function setUp(): void
 
     private function __reflectAndSetupAccessibleForProtectedTraitMethod($methodName)
     {
-        $migrateFreshUsingReflection = new ReflectionMethod(
+        return new ReflectionMethod(
             get_class($this->traitObject),
             $methodName
         );
-
-        return $migrateFreshUsingReflection;
     }
 
     public function testMigrateFreshUsingDefault(): void