[11.x] Allow using castAsJson() on non default db connection during…

… test (#53256) * [11.x] Allow using `castAsJson()` on non default db connection during test Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> --------- Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
laravel · Oct 21, 2024 · ebd5b6e · ebd5b6e
1 parent 3807ec7
commit ebd5b6e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php b/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php
@@ -231,20 +231,23 @@ protected function isSoftDeletableModel($model)
      * Cast a JSON string to a database compatible type.
      *
      * @param  array|object|string  $value
+     * @param  string|null  $collection
      * @return \Illuminate\Contracts\Database\Query\Expression
      */
-    public function castAsJson($value)
+    public function castAsJson($value, $connection = null)
     {
         if ($value instanceof Jsonable) {
             $value = $value->toJson();
         } elseif (is_array($value) || is_object($value)) {
             $value = json_encode($value);
         }
 
-        $value = DB::connection()->getPdo()->quote($value);
+        $db = DB::connection($connection);
 
-        return DB::raw(
-            DB::connection()->getQueryGrammar()->compileJsonValueCast($value)
+        $value = $db->getPdo()->quote($value);
+
+        return $db->raw(
+            $db->getQueryGrammar()->compileJsonValueCast($value)
         );
     }
 

diff --git a/tests/Testing/Concerns/InteractsWithDatabaseTest.php b/tests/Testing/Concerns/InteractsWithDatabaseTest.php
@@ -149,15 +149,15 @@ protected function castAsJson($value, $grammar)
 
         $connection->shouldReceive('getQueryGrammar')->andReturn($grammar);
 
+        $connection->shouldReceive('raw')->andReturnUsing(function ($value) {
+            return new Expression($value);
+        });
+
         $connection->shouldReceive('getPdo->quote')->andReturnUsing(function ($value) {
             return "'".$value."'";
         });
 
-        DB::shouldReceive('connection')->andReturn($connection);
-
-        DB::shouldReceive('raw')->andReturnUsing(function ($value) {
-            return new Expression($value);
-        });
+        DB::shouldReceive('connection')->with(null)->andReturn($connection);
 
         $instance = new class
         {