Default paginator indicators shouldn't have an 'active' class #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dries Vints <dries.vints@gmail.com>
Default paginator indicators shouldn't have an 'active' class. The 'active' class was meant to indicate the current active page, not a clickable link to a page. Also because of this, the 'active' class should never be used on 'previous' or 'next' links. 'Previous' or 'next' links are only meant to move towards the previous or next page in the sequence. They shouldn't indicate an 'active' page stage because they aren't page indicators. See the Twitter Bootstrap docs under Pagination > Options > Disabled and active states for more info. Signed-off-by: Dries Vints <dries.vints@gmail.com>
Update unit tests for the previous commit. Signed-off-by: Dries Vints <dries.vints@gmail.com>
|
This is a good PR but the Unit Tests are still failing in Travis, maybe you should have another look at them. |
|
Yep, fixing atm :) |
Forgot some classes on previous commit. Signed-off-by: Dries Vints <dries.vints@gmail.com>
|
This has been fixed. |
joelharkes
pushed a commit
to joelharkes/framework_old
that referenced
this pull request
Mar 7, 2019
…ument-endpoint Delete and show subscription document endpoint
dbpolito
pushed a commit
to dbpolito/framework
that referenced
this pull request
Oct 1, 2019
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in the commit and title, default paginator indicators shouldn't have an 'active' class. The 'active' class was meant to indicate the current active page, not a clickable link to a page.
Also because of this, the 'active' class should never be used on 'previous' or 'next' links. 'Previous' or 'next' links are only meant to move towards the previous or next page in the sequence. They shouldn't indicate an 'active' page stage because they aren't page indicators.
See the Twitter Bootstrap docs under
Pagination > Options > Disabled and active statesfor more info.Fixes #100.