Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix SoftDeletes forceDelete return #13272

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Conversation

jn-jairo
Copy link
Contributor

The function forceDelete did not return the result.

@jn-jairo jn-jairo changed the title Fix SoftDeletes forceDelete return [5.2] Fix SoftDeletes forceDelete return Apr 22, 2016
@GrahamCampbell
Copy link
Member

This is intended, as indicated by the return phpdoc.

@jn-jairo
Copy link
Contributor Author

But in Model class the function forceDelete() return bool|null and the funtion delete() return bool|null, why the SoftDeletes change this to return always null?

@GrahamCampbell
Copy link
Member

Meh, I don't mind I guess. You can't have it as bool|void though. void cannot be mixed since it means garbage, not null.

@jn-jairo
Copy link
Contributor Author

I understand, my mistake, I forgot to change void to null. I change to bool|null is this correct now?

@taylorotwell taylorotwell merged commit 151ead9 into laravel:5.2 Apr 25, 2016
@jn-jairo jn-jairo deleted the patch-1 branch April 25, 2016 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants