[5.1] Fixing scheduler switch user with withoutOverlapping together not working

[pulkitjalan]

Fixes #13332

[GrahamCampbell]

What about windows support?

[pulkitjalan]

Ah... Sorry didn't test Windows.

Does sudo -u work on Windows anyway?

Also what terminal on Windows, the native one?

[GrahamCampbell]

We need to get it to ignore the user flag on windows.

[pulkitjalan]

ok, so this be ok? or do you think there should also be a check in the user() function for if windows throw exception?

if (windows_os()) {
    return $command;
}

return $this->user ? 'sudo -u '.$this->user.' -- sh -c \''.$command.'\'' : $command;

[GrahamCampbell]

I was just thinking: return $this->user && ! windows_os() ? 'sudo -u '.$this->user.' -- sh -c \''.$command.'\'' : $command;

[pulkitjalan]

Cool, done that. Thanks.