[5.2] Fire the RouteMatched event on route:list command

[themsaid]

As described here #13453, FormRequests wouldn't get initialised properly when being resolved from the routes:list command, this is because the initialisation logic only runs when the RouteMatched event is fired.

Check:

framework/src/Illuminate/Foundation/Providers/FoundationServiceProvider.php

Line 45 in b18c01e

$this->app['events']->listen(RouteMatched::class, function () {

[taylorotwell]

But we're not passing anything to the event. Wouldn't any listener thats trying to access the event's data fail?

[themsaid]

Yes, you're right, it just seemed that no listener is using the event attributes in the core that's why I didn't notice there are any in the event class constructor.

What do you think if we remove the event listener from the provider and just use $this->app->resolving? Here it doesn't need to know about the route or the request (Event Parameters), so I assume it should be ok, no?

$this->app->resolving(function (FormRequest $request, $app) {
    $this->initializeRequest($request, $app['request']);

    $request->setContainer($app)->setRedirector($app->make(Redirector::class));
});

Or should we fire the event for every route inside the foreach loop of the command?

foreach ($this->routes as $route)

[taylorotwell]

You can try changing to resolving. I'm not sure what effects that may have.

[themsaid]

@taylorotwell changed the code so that the resolving call back is registered by default regardless of whether the RouteMatched event is fired or not.

[taylorotwell]

I wonder why I had it only registering if Route Matched before? :/

[themsaid]

Yeah I was confused about that, but thought maybe there's some reason I'm not aware of.