[5.2] Set connection timeout for mail transports #13621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe make it a config option? |
GrahamCampbell
changed the title
and add default config for it on HttpClient in TransportManager
|
i see it now, in TransportManager they made pussible set guzzle config for driver's that work with guzzle, 'sparkpost' => [
'secret' => 'c0100484e20bfa12e20632b1d9b4761a51c482c2',
'guzzle' => [
'connect_timeout' =>60,
],
]i added the getHttpClient to create http client |
i push die setting by mistake, sorry
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
By sending this PR I want to set connection timeout for drivers that use GuzzleHttp to send request
GuzzleHttp Use 0 to wait indefinitely (the default behavior) for connection timeout and that's really bad for background jobs like queue
it could cause infinite loops.
Regards,