Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Update MySqlConnector.php. Sometimes we don't need to set names and collate. #13930

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

mixisLv
Copy link
Contributor

@mixisLv mixisLv commented Jun 10, 2016

For me this is very important and i don't see other ways how to do this.

Sometimes we don't need  to set names and collate.
@GrahamCampbell GrahamCampbell changed the title Update MySqlConnector.php. Sometimes we don't need to set names and collate. [5.1] Update MySqlConnector.php. Sometimes we don't need to set names and collate. Jun 10, 2016
@GrahamCampbell
Copy link
Member

Please could you describe what this does and add a couple of tests.

@mixisLv
Copy link
Contributor Author

mixisLv commented Jun 13, 2016

When a database connection is established, the mysql db driver will always call "SET NAMES '$charset' collate '$collation'". This patch renders it optional, rather than mandatory. Similar to timezone settings.

@taylorotwell taylorotwell merged commit 163efce into laravel:5.1 Jun 14, 2016
@mixisLv mixisLv deleted the 5.1 branch June 14, 2016 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants